Skip to content

Ensure to give path that doesn’t exist for copying repo#1311

Merged
pipecd-bot merged 1 commit intomasterfrom
give-path
Dec 22, 2020
Merged

Ensure to give path that doesn’t exist for copying repo#1311
pipecd-bot merged 1 commit intomasterfrom
give-path

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
Usage of copying repo became clear from the discussion on #1296

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.61%. This pull request decreases coverage by -0.11%.

File Function Base Head Diff
pkg/app/api/grpcapi/api.go API.ListApplications -- 0.00% +0.00%
pkg/app/api/grpcapi/utils.go listApplications -- 0.00% +0.00%
pkg/model/common.go ApplicationKindStrings -- 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Dec 22, 2020

/lgtm

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 4b8fe5c into master Dec 22, 2020
@pipecd-bot pipecd-bot deleted the give-path branch December 22, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants